Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmod-*-nvidia: specify AWS EULA as license #3991

Merged
merged 1 commit into from
May 29, 2024

Conversation

bcressey
Copy link
Contributor

Issue number:

Closes #3990

Description of changes:
Previously, the NVIDIA packages were special-cased with a "bring your own license" step, to support the case where a developer building the project might choose the terms of a different license under which to distribute the software or to make it available to end users.

With the advent of out-of-tree builds, packages are moving into kits that contain pre-compiled binary RPMs, which means they will always have a header indicating which license applies.

This commit makes it explicit what license those RPMs will have at the time they are published.

Since the terms of the AWS EULA indicate that the software should be used to develop AMIs for use on AWS, add an install-time requirement for aws-* variants.

Testing done:

❯ ls -1 build/rpms/bottlerocket-kmod-*-nvidia-*tesla*.rpm
build/rpms/bottlerocket-kmod-5.10-nvidia-tesla-470-470.239.06-1.aarch64.rpm
build/rpms/bottlerocket-kmod-5.10-nvidia-tesla-470-470.239.06-1.x86_64.rpm
build/rpms/bottlerocket-kmod-5.15-nvidia-tesla-535-535.161.07-1.aarch64.rpm
build/rpms/bottlerocket-kmod-5.15-nvidia-tesla-535-535.161.07-1.x86_64.rpm
build/rpms/bottlerocket-kmod-6.1-nvidia-tesla-535-535.161.07-1.aarch64.rpm
build/rpms/bottlerocket-kmod-6.1-nvidia-tesla-535-535.161.07-1.x86_64.rpm

❯ rpm -qip build/rpms/bottlerocket-kmod-*-nvidia-*tesla*.rpm|rg License
License     : LicenseRef-NVIDIA-AWS-EULA
License     : LicenseRef-NVIDIA-AWS-EULA
License     : LicenseRef-NVIDIA-AWS-EULA
License     : LicenseRef-NVIDIA-AWS-EULA
License     : LicenseRef-NVIDIA-AWS-EULA
License     : LicenseRef-NVIDIA-AWS-EULA

❯ rpm -qlp build/rpms/bottlerocket-kmod-*-nvidia-*tesla*.rpm|rg EULA
/aarch64-bottlerocket-linux-gnu/sys-root/usr/share/licenses/kmod-5.10-nvidia/NVidiaEULAforAWS.pdf
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/licenses/kmod-5.10-nvidia/NVidiaEULAforAWS.pdf
/aarch64-bottlerocket-linux-gnu/sys-root/usr/share/licenses/kmod-5.15-nvidia/NVidiaEULAforAWS.pdf
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/licenses/kmod-5.15-nvidia/NVidiaEULAforAWS.pdf
/aarch64-bottlerocket-linux-gnu/sys-root/usr/share/licenses/kmod-6.1-nvidia/NVidiaEULAforAWS.pdf
/x86_64-bottlerocket-linux-gnu/sys-root/usr/share/licenses/kmod-6.1-nvidia/NVidiaEULAforAWS.pdf

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Previously, the NVIDIA packages were special-cased with a "bring your
own license" step, to support the case where a developer building the
project might choose the terms of a different license under which to
distribute the software or to make it available to end users.

With the advent of out-of-tree builds, packages are moving into kits
that contain pre-compiled binary RPMs, which means they will always
have a header indicating which license applies.

This commit makes it explicit what license those RPMs will have at
the time they are published.

Since the terms of the AWS EULA indicate that the software should be
used to develop AMIs for use on AWS, add an install-time requirement
for `aws-*` variants.

Signed-off-by: Ben Cressey <[email protected]>
@bcressey bcressey merged commit c48c41a into bottlerocket-os:develop May 29, 2024
33 checks passed
@bcressey bcressey deleted the kmod-nvidia-license branch May 29, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to predefined license for kmod-*-nvidia
4 participants